Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error links to the error index could open in a new tab #283

Closed
lqd opened this issue Mar 30, 2018 · 0 comments
Closed

Error links to the error index could open in a new tab #283

lqd opened this issue Mar 30, 2018 · 0 comments
Assignees
Labels
enhancement Something new the playground could do

Comments

@lqd
Copy link
Member

lqd commented Mar 30, 2018

The compiler error codes are turned into links to the error index documentation, however these links open in the same page and not a new tab, making users feel like they just lost their code.

We could add a target="_blank" to those error links. And is somewhat related to #207.

(Of course, they didn't really lose anything as the code is saved in browser storage, but first-time users don't know about this feature until going back to the playground).

This actually happened in real life when I was showing the playground to a new rust user, they clicked the error and gasped in terror :)

@shepmaster shepmaster self-assigned this Apr 26, 2018
@shepmaster shepmaster added the enhancement Something new the playground could do label Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something new the playground could do
Projects
None yet
Development

No branches or pull requests

2 participants