Skip to content

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Aug 13, 2025

Closes #15388

changelog: [semicolon_inside_block] fix FP when attribute over expr is not enabled

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2025
ada4a added a commit to ada4a/rust-clippy that referenced this pull request Aug 13, 2025
ada4a added a commit to ada4a/rust-clippy that referenced this pull request Aug 13, 2025
ada4a added a commit to ada4a/rust-clippy that referenced this pull request Aug 13, 2025
Copy link
Contributor

@ada4a ada4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this! I now realize that I should've incorporated the feature check into #15466 as well. Speaking of which..

ada4a added a commit to ada4a/rust-clippy that referenced this pull request Aug 22, 2025
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Aug 24, 2025
Merged via the queue into rust-lang:master with commit 0126bc9 Aug 24, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 24, 2025
@profetia profetia deleted the issue15388 branch September 12, 2025 01:23
github-merge-queue bot pushed a commit that referenced this pull request Sep 22, 2025
…#15481)

inspired by #15476

changelog: [`unnecessary_semicolon`]: FN on
`#[feature(stmt_expr_attributes)]`

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_SUMMARY_START -->

### Summary Notes

- [Feature
freeze](#15481 (review))
by [blyxyas](https://github.com/blyxyas)

*Managed by `@rustbot`—see
[help](https://forge.rust-lang.org/triagebot/note.html) for details*

<!-- TRIAGEBOT_SUMMARY_END -->
<!-- TRIAGEBOT_END -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

semicolon_inside_block turns stmts into exprs, breaking attributes

4 participants