-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix semicolon_inside_block FP when attribute over expr is not enabled
#15476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Aug 13, 2025
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Aug 13, 2025
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Aug 13, 2025
…is enabled inspired by rust-lang#15476
ada4a
reviewed
Aug 13, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this! I now realize that I should've incorporated the feature check into #15466 as well. Speaking of which..
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Aug 13, 2025
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Aug 13, 2025
This was referenced Aug 13, 2025
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Aug 22, 2025
blyxyas
approved these changes
Aug 24, 2025
Member
blyxyas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! ❤️
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
…#15481) inspired by #15476 changelog: [`unnecessary_semicolon`]: FN on `#[feature(stmt_expr_attributes)]` <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> ### Summary Notes - [Feature freeze](#15481 (review)) by [blyxyas](https://github.com/blyxyas) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details* <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15388
changelog: [
semicolon_inside_block] fix FP when attribute over expr is not enabled