{borrow,ptr}_as_ptr: don't lint inside proc-macros
#15473
Merged
+75
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
we return `false` outside of the `if` anyway
ada4a
force-pushed
the
borrow-and-ptr-as-ptr
branch
from
dd2d448 to
0470d0f
Compare
Jarcho
requested changes
Aug 15, 2025
Contributor
Jarcho
left a comment
Jarcho
left a comment
There was a problem hiding this comment.
The last commit is not correct. is_from_proc_macro is actually broken and doesn't account for macro variables at all. I would just revert that change and leave a FIXME note in it's place.
rustbot
added
S-waiting-on-author
Jarcho
reviewed
Aug 15, 2025
Jarcho
approved these changes
Aug 15, 2025
Contributor
Jarcho
left a comment
Jarcho
left a comment
There was a problem hiding this comment.
Thank you. Can you just squash the last three commits down please.
notice that this stops `inline!` from working as well
ada4a
force-pushed
the
borrow-and-ptr-as-ptr
branch
from
03a39ec to
9570ed8
Compare
Contributor
Author
|
done! |
ada4a
changed the title
{borrow,ptr}_as_ptr{borrow,ptr}_as_ptr: don't lint inside proc-macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this could arguably be 2 separate PRs, but both of these were brought up in the same issue, so..
fixes #15398
changelog: [
borrow_as_ptr]: don't lint inside proc-macroschangelog: [
ptr_as_ptr]: don't lint inside proc-macros