-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle false positive with map_clone
lint
#12282
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Clippy 👋
You already found the right location to edit. You ran into a difficulty with this lint, but that should be fixable. Please reach out, if you have any questions or get stuck, I'm happy to help more :D
@xFrednet Fixed the code. Let me know if something is still wrong. |
r? xFrednet |
Could not assign reviewer from: |
☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts. |
Failed to set assignee to
|
Could not assign reviewer from: |
Hey, sorry, this PR got lost in my inbox 🙈 This version looks good, I added one comment, to your question. Once we've checked this, we can merge the PR. |
@xFrednet Thank you for your comment. It should be okay for merge. |
Perfect, looks good to me, thank you for the fix :D @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Summary
map_clone
#12271changelog: [
map_clone
]: Handle false positive withmap_clone
lint