Skip to content

Conversation

@blyxyas
Copy link
Member

@blyxyas blyxyas commented Apr 24, 2023

In cargo fix's documentation they indicate that fix implies --all-targets if no target is supplied. As Clippy uses Cargo under the hood, this also applies to Clippy, but we didn't document that behaviour.

This PR changes that

Fixes #10690
changelog: Add to documentation that --fix implies --all-targets

@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 24, 2023
@blyxyas blyxyas changed the title Add the warning to all documentation. Document that cargo clippy --fix implies --all-targets Apr 24, 2023
@blyxyas blyxyas force-pushed the fix-fixflag_implies_all_targets branch from f4e85cf to 4a76b6f Compare April 25, 2023 00:05
@llogiq
Copy link
Contributor

llogiq commented Apr 25, 2023

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2023

📌 Commit 4a76b6f has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 25, 2023

⌛ Testing commit 4a76b6f with merge a7335cb...

@bors
Copy link
Contributor

bors commented Apr 25, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing a7335cb to master...

@bors bors merged commit a7335cb into rust-lang:master Apr 25, 2023
@blyxyas blyxyas deleted the fix-fixflag_implies_all_targets branch October 5, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo clippy --fix seems to imply --tests which is at least undocumented

4 participants