Fix: Some suggestions generated by the option_if_let_else lint did not compile

[EliasHolzmann]

This addresses a bug in Clippy where the fix suggestend by the option_if_let_else lint would not compile for Results which have an impure expression in the else branch.

---

changelog: [option_if_let_else]: Fixed incorrect suggestion for Results
#10337

Fixes #10335.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

[bors]

☔ The latest upstream changes (presumably #10434) made this pull request unmergeable. Please resolve the merge conflicts.

[EliasHolzmann]

@flip1995 Did you have an opportunity to review this already? If you're busy, I can assign someone else to review this.

[dswij]

Thanks for the patience @EliasHolzmann. I will assign this to myself and review this soon

r? @dswij

[dswij]

This looks great. Thanks for opening the PR together with the issue

[dswij]

@bors r+

[bors]

📌 Commit d80ca09 has been approved by dswij

It is now in the queue for this repository.

[bors]

⌛ Testing commit d80ca09 with merge 407c352...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 407c352 to master...

[EliasHolzmann]

Thanks for opening the PR together with the issue

Sure! Thank you for getting this merged!