Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend invalid_atomic_ordering lint to memory fence calls #5026

Closed
krishna-veerareddy opened this issue Jan 9, 2020 · 1 comment · Fixed by #5028
Closed

Extend invalid_atomic_ordering lint to memory fence calls #5026

krishna-veerareddy opened this issue Jan 9, 2020 · 1 comment · Fixed by #5028
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages L-correctness Lint: Belongs in the correctness lint group

Comments

@krishna-veerareddy
Copy link
Contributor

krishna-veerareddy commented Jan 9, 2020 •
edited
Loading

core::sync::atomic::{fence, compiler_fence} functions will panic when called with Relaxed ordering so we should lint such calls under the invalid_atomic_ordering lint. I can start working on this issue if nobody has any objections.
@JohnTitor
Copy link
Member

It seems reasonable to me.

@JohnTitor JohnTitor added L-correctness Lint: Belongs in the correctness lint group C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages labels Jan 9, 2020
@krishna-veerareddy krishna-veerareddy mentioned this issue Jan 9, 2020
Merged
@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
@bors bors closed this as completed in dd06c06 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages L-correctness Lint: Belongs in the correctness lint group
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect usage of invalid atomic ordering in memory fences krishna-veerareddy/rust-clippy
2 participants
@JohnTitor @krishna-veerareddy