New lint: comparing option to Some(true)

[ghost]

Suggest replacing the expression x == Some(true) with x.unwrap_or(false). To me the second form better expresses what's going on: use the value in x otherwise default to false.

This is similar to the bool_comparison lint but I guess it could be more controversial. I'm OK if it's pedantic or restriction depending on what other people think.

[lolbinarycat]

the latter is longer, uses a method readers may not be very familiar with (in comparison, every programmer should immediately know what == means), only works with booleans (whereas == Some(x) works on any PartialEq type) and may have worse performance on debug builds (function call instead of a simple bitwise comparison).

if this is implemented, i think it should definitely be restriction.