Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper warning about useless_let_if_seq #4914

Closed
wdanilo opened this issue Dec 19, 2019 · 1 comment
Closed

Improper warning about useless_let_if_seq #4914

wdanilo opened this issue Dec 19, 2019 · 1 comment

Comments

@wdanilo
Copy link

wdanilo commented Dec 19, 2019

Hi, the following code:

        let mut changed = false;
        if self.transform_dirty.check() {
            ...
            changed = true;
        }
        if self.projection_dirty.check() {
            ...
            changed = true;
        }
        if changed {
            ...
        }

gives a warning:

help: it is more idiomatic to write: `let <mut> changed = if self.transform_dirty.check() { ..; true } else { false };`

Which I believe could not be applied here.

@ghost
Copy link

ghost commented Dec 19, 2019

Duplicate of #3769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants