bad match_ref_pats suggestion.

[Lokathor]

In this line of this file of this commit, clippy says "you don't need to add & to all patterns", but because the & is actually changing the type of the binding, if you take off that & then the type going into png_u16 become wrong and the code doesn't compile.

[flip1995]

We shouldn't emit this lint if the match is on &[T].

[ebroto]

The lint also suggests to dereference the scrutinee. Wouldn't that work as expected?

fn test() {
    let v: &[i32] = &[1, 2, 3, 4];

    #[allow(clippy::single_match)]
    match *v {
        [a0, a1, b0, b1] => {
            takes_arr([a0, b0]);
            takes_arr([a1, b1]);
        },
        _ => {},
    }
}

fn takes_arr(_: [i32; 2]) {}

fn main() {
    test();
}

(playground)