Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should //run-rustfix tests apply HasPlaceholders suggestions? #4557

Open
Manishearth opened this issue Sep 20, 2019 · 3 comments
Open

Should //run-rustfix tests apply HasPlaceholders suggestions? #4557

Manishearth opened this issue Sep 20, 2019 · 3 comments

Comments

@Manishearth
Copy link
Member

Applying // run-rustfix to tests/ui/float_cmp_const.rs causes the HasPlaceholders suggestions contained within that lint to be applied.

Do we actually want this behavior? HasPlaceholders suggestions are things that should be applied manually imo.
@sinkuu
Copy link
Contributor

sinkuu commented Sep 20, 2019

// run-rustfix seems to apply even MaybeIncorrect ones, unless there is rustfix-only-machine-applicable directive. 😞

@flip1995
Copy link
Member

There is // rustfix-only-machine-applicable, which we could add to those lints. If we run cargo fix --clippy only the MachineApplicable lints get applied? In that case we could run rustfix tests only for MachineApplicable lints.

@Manishearth
Copy link
Member Author

Maybe we should invert those? But that sounds annoying too, maybe we should just close this.

@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Manishearth @sinkuu @flip1995