-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy broken on nightly #3506
Comments
relevant log output
|
the PR changed the libc module, so I guess libc::c_void changed under the hood causing clippy to additionally issue this warning. If this is a TP, a simple test stderr update should suffice. (I'm not that familiar with libc myself though) |
We should not report a lint on this situation. We have an exception for
|
More specifically this seems to have been caused by this libc update: rust-lang/libc@c75ca64...5b40375 which was included in the SGX PR. |
Pretty sure it was caused by this commit: rust-lang/libc@5c1a6b8. Now I will just have to figure out the new path of libc::cvoid. |
This is weird. I think I found a bug in The ty path of the void type correctly reports This is a problem because
Because they are different, the lint is triggered. I'm not sure what the best fix would be here. @oli-obk
|
I need another coffee. The path and def_id are different because that's what we pass into That rules out |
rust-lang/rust#56066 (comment) broke clippy. Not sure how yet.
The text was updated successfully, but these errors were encountered: