Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest replacing if option.is_none() { return None; } with option?; #2358

Closed
shssoichiro opened this issue Jan 15, 2018 · 2 comments
Closed

Suggest replacing if option.is_none() { return None; } with option?; #2358

shssoichiro opened this issue Jan 15, 2018 · 2 comments
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience. good-first-issue These issues are a good way to get started with Clippy L-unnecessary Lint: Warn about unnecessary code T-middle Type: Probably requires verifiying types

Comments

@shssoichiro
Copy link
Contributor

See #2353 (comment)
@oli-obk oli-obk added good-first-issue These issues are a good way to get started with Clippy E-medium Call for participation: Medium difficulty level problem and requires some initial experience. T-middle Type: Probably requires verifiying types A-lint Area: New lints L-unnecessary Lint: Warn about unnecessary code labels Jan 16, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Jan 16, 2018

There's probably more complex cases. Not sure what to do about those and what they even are. The base lint is a good first issue, everything else E-medium

@gnieto gnieto mentioned this issue Jan 29, 2018
Merged
@camsteffen
Copy link
Contributor

This is now linted by question_mark.

@oli-obk oli-obk closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience. good-first-issue These issues are a good way to get started with Clippy L-unnecessary Lint: Warn about unnecessary code T-middle Type: Probably requires verifiying types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oli-obk @Manishearth @camsteffen @shssoichiro