Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyclomatic Complexity should not count code in debug_assert #2249

Open
oli-obk opened this issue Nov 28, 2017 · 1 comment
Open

Cyclomatic Complexity should not count code in debug_assert #2249

oli-obk opened this issue Nov 28, 2017 · 1 comment

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2017

Found an allow(cyclomatic_complexity) in chrono:

chronotope/chrono@4c18d70

I assume that all the complexity comes from the expansion of these assert macros. We should treat them as function calls.
@antoyo
Copy link

antoyo commented Sep 11, 2018

Same in tests function for assert! and assert_eq!.

@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @antoyo