Typedefs and ptr_arg lint

[stanislav-tkach]

I have the following situation:

type Value = Vec<u8>;

fn foo(_: &Value) {}

Typedef is used for clarity, but Clippy produces a warning:

warning: writing &Vec<_> instead of &[_] involves one more reference and cannot be used with non-Vec-based slices. Consider changing the type to &[...]

Probably this lint can be disabled for typedes?

[oli-obk]

Probably this lint can be disabled for typedefs?

hmm... I think it would be ok to disable the lint on typedefs if the function is not public. But if it's public, you're gonna limit your callers needlessly.

[stanislav-tkach]

In my case both function and typedef isn't public. 😄

[algesten]

My types are public but it's an internal library where I clarify what is what using type defs. However I won't ever need &str instead of &String. I'm not sure about this lint :/

[oli-obk]

Maybe we should rewrite this lint as a PreExpansionPass and simply check for literal &String and &Vec<T> even if this causes false positives when someone creates their own types named String or Vec

[algesten]

That sounds like a great idea!