Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatically applicable suggestion to unused_label #1850

Open
killercup opened this issue Jun 25, 2017 · 0 comments
Open

Add automatically applicable suggestion to unused_label #1850

killercup opened this issue Jun 25, 2017 · 0 comments
Labels
A-lint Area: New lints L-suggestion Lint: Improving, adding or fixing lint suggestions

Comments

@killercup
Copy link
Member

killercup commented Jun 25, 2017

Found by running rustfix on https://github.com/space-wizards/bsdiff-rs.

I suggest suggesting (heh) to replace 'loop7: with an empty string. (Might need special casing in diagnostics rendering?)

warning: unused label `'loop7`
   --> src/diff.rs:468:13
    |
468 | /             'loop7: loop {
469 | |                 if !(scsc < scan + len) {
470 | |                     break;
471 | |                 }
...   |
477 | |                 scsc += 1isize;
478 | |             }
    | |_____________^
    |
    = note: #[warn(unused_label)] on by default
    = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_label
@mcarton mcarton added L-suggestion Lint: Improving, adding or fixing lint suggestions A-lint Area: New lints labels Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: New lints L-suggestion Lint: Improving, adding or fixing lint suggestions
Projects
None yet
Development

No branches or pull requests

2 participants