Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should_implement_trait should include ToOwned, FromStr #1600

Open
clarfonthey opened this issue Mar 4, 2017 · 1 comment
Open

should_implement_trait should include ToOwned, FromStr #1600

clarfonthey opened this issue Mar 4, 2017 · 1 comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group T-middle Type: Probably requires verifiying types

Comments

@clarfonthey
Copy link
Contributor

clarfonthey commented Mar 4, 2017 •
edited
Loading

Also see: servo/rust-url#286.

For FromStr, clippy should recommend that parse methods be renamed to from_str.
@clarfonthey clarfonthey changed the title should_implement_trait should include ToOwned should_implement_trait should include ToOwned, FromStr Mar 4, 2017
@oli-obk oli-obk added L-style Lint: Belongs in the style lint group good-first-issue These issues are a good way to get started with Clippy C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages T-middle Type: Probably requires verifiying types labels Mar 4, 2017
@clarfonthey
Copy link
Contributor Author

Also adding onto this: perhaps it'd be a good idea to look at all of the new traits in the stdlib and update this lint so that it includes all of them.

@SamWhited SamWhited mentioned this issue May 6, 2017
Open
@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group T-middle Type: Probably requires verifiying types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oli-obk @Manishearth @flip1995 @clarfonthey