Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint unwrap in drop impls #1523

Open
killercup opened this issue Feb 8, 2017 · 2 comments
Open

Lint unwrap in drop impls #1523

killercup opened this issue Feb 8, 2017 · 2 comments
Labels
A-lint Area: New lints E-hard Call for participation: This a hard problem and requires more experience or effort to work on good-first-issue These issues are a good way to get started with Clippy L-correctness Lint: Belongs in the correctness lint group T-middle Type: Probably requires verifiying types

Comments

@killercup
Copy link
Member

Would it make sense to deny panic-able fns in Drop::drop implementations? It recently came up in diesel-rs/diesel#641 (comment).
@oli-obk
Copy link
Contributor

oli-obk commented Feb 8, 2017

requires #959

@oli-obk oli-obk added L-correctness Lint: Belongs in the correctness lint group good-first-issue These issues are a good way to get started with Clippy E-hard Call for participation: This a hard problem and requires more experience or effort to work on A-lint Area: New lints T-middle Type: Probably requires verifiying types labels Feb 8, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Feb 8, 2017

marking e-easy and e-hard, because it's easy to do after #959

@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints E-hard Call for participation: This a hard problem and requires more experience or effort to work on good-first-issue These issues are a good way to get started with Clippy L-correctness Lint: Belongs in the correctness lint group T-middle Type: Probably requires verifiying types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@killercup @oli-obk @Manishearth @flip1995