-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable inheriting of clippy.toml
#1295
Comments
Here's my ideal world: Cargo.toml [dev-dependencies]
clippy = "1.0.0"
clippy-integer32-preset = "2.1.8"
clippy-shepmaster-preset = "0.55.3" clippy.toml inherit-from = ["integer32", "shepmaster"]
# project-specific-settings This is based on similar concepts from ESLint and Rubocop, both of which allow bundling up settings (and even additional lints!) from a reusable library. |
|
Probably, yes. However, I could also see a much smaller group of people producing their own Clippy lints this way. For example, there are Rubocop lints specific to RSpec, but which are produced by an unassociated third party.
The biggest benefits I see from this are:
I think any solution that handles those would be a great one, leveraging the crates ecosystem is just the one that comes to mind based on the two examples I'm already familiar with.
Or reference from GitHub, or have a local directory, etc. Any of the normal Cargo distribution mechanisms. |
This is the kind of thing that could also be interesting for |
Hum, that does not work, cc @nrc |
We need to decide what to do in case of conflict:
|
I think that the values that can't be merged should be overwritten |
If we overwrite values, this should come with at least a warning. |
add a field to
clippy.toml
that allows it to refer to a git repository or a path where aclippy.toml
is located. Pre-initialize all settings from the referredclippy.toml
and then overwrite with the localclippy.toml
.Open questions:
clippy.toml
clippy.toml
allowed to refer to others itself?The text was updated successfully, but these errors were encountered: