Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignored-unit-patterns shouldn't look inside macro invocations #11601

Closed
mpalmer opened this issue Oct 3, 2023 · 1 comment · Fixed by #11602
Closed

ignored-unit-patterns shouldn't look inside macro invocations #11601

mpalmer opened this issue Oct 3, 2023 · 1 comment · Fixed by #11602
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have

Comments

@mpalmer
Copy link

mpalmer commented Oct 3, 2023

Summary

I'm getting CI failures on a project that uses Deku because it trips the ignored-unit-patterns lint inside the DekuRead and DekuWrite derive macros (such as in this run). It doesn't seem useful for this lint to fire on code I can't control.

Lint Name

ignored-unit-patterns

Reproducer

No response

Version

rustc 1.75.0-nightly (2e5a9dd6c 2023-10-02)
binary: rustc
commit-hash: 2e5a9dd6c9eaa42f0684b4b760bd68fc27cbe51b
commit-date: 2023-10-02
host: x86_64-unknown-linux-gnu
release: 1.75.0-nightly
LLVM version: 17.0.2

Additional Labels

No response
@mpalmer mpalmer added C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have labels Oct 3, 2023
@koka831 koka831 mentioned this issue Oct 3, 2023
Merged
@bors bors closed this as completed in 29958f0 Oct 3, 2023
@mpalmer
Copy link
Author

mpalmer commented Oct 4, 2023

This is... amazing. Thanks so much, @bors! 😻

@frederikhors frederikhors mentioned this issue Oct 20, 2023
Closed
@elasticdog elasticdog mentioned this issue Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid invoking ignored_unit_patterns in macro definition koka831/rust-clippy
1 participant
@mpalmer