Clippy suggests using a for-loop instead of while-let, even when the for loop doesn't compile.

[DemiMarie]

Clippy suggests using a for loop instead of any while let loop over an iterator. But this gives a lifetime error if we don't own the iterator.

[Manishearth]

You may need to for i in &iter

probably can improve the suggestion, bit tricky though.

[llogiq]

That can fail if &iter fails to implement Iterator though. I have also seen cases where the iterator was used after the loop, which gives us trouble because for loops consume their iterators.

[DemiMarie]

I am in the latter case: the iterator outlives the loop (and, in some
cases, is used by the loop body).

On Aug 9, 2016 12:29 AM, "llogiq" [email protected] wrote:

That can fail if &iter fails to implement Iterator though. I have also
seen cases where the iterator was used after the loop, which gives us
trouble because for loops consume their iterators.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Manishearth/rust-clippy/issues/1156#issuecomment-238450470,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGGWB3VruxLAJuspbxRxLFd4ecE1eQA9ks5qeAIpgaJpZM4JfsQo
.

[Manishearth]

So does &iter work?

[DemiMarie]

Not in my case, where the iterator is already a reference.

On Aug 9, 2016 2:13 AM, "Manish Goregaokar" [email protected]
wrote:

So does &iter work?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Manishearth/rust-clippy/issues/1156#issuecomment-238463020,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGGWB_VMfi6_258VpmGAWmGeUYtEKb1bks5qeBqRgaJpZM4JfsQo
.

[Manishearth]

References are Copy though. It's fine to use them like this. Is it a mutable reference? In that case, does &mut iter work?

Could you post a snippet of the function?

[leoyvens]

Similar to #600

[DemiMarie]

In my case I use the iterator in the loop body.

On Aug 17, 2016 08:05, "Leonardo Yvens" [email protected] wrote:

Similar to #600 https://github.com/Manishearth/rust-clippy/issues/600

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Manishearth/rust-clippy/issues/1156#issuecomment-240391783,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGGWB7YLiT-whTF3f42WN1MqQgBPEMi0ks5qgvkNgaJpZM4JfsQo
.