Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust toolchain version? #11490

Closed
EFanZh opened this issue Sep 13, 2023 · 8 comments
Closed

Update Rust toolchain version? #11490

EFanZh opened this issue Sep 13, 2023 · 8 comments

Comments

@EFanZh
Copy link

EFanZh commented Sep 13, 2023

Description

Currently, Clippy is not able to be compiled with the latest Rust toolchain (For example: nightly-2023-09-10) due to API change, I think we may need to merge changes from rust-lang/rust@f49382c into this repository. Now I can help submit a PR, but I am not sure if there is a specific workflow for synchronizing commits between these two repositories (For example: keeping commit authors, dates, etc).

Version

rustc 1.74.0-nightly (8ed4537d7 2023-09-09)
binary: rustc
commit-hash: 8ed4537d7c238eb77509d82445cf1cb861a3b5ff
commit-date: 2023-09-09
host: x86_64-unknown-linux-gnu
release: 1.74.0-nightly
LLVM version: 17.0.0

Additional Labels

No response

@Alexendoo
Copy link
Member

It gets synced every couple weeks, the process is documented here. The nightly will be updated after rust-lang/rust#115790 is completed

If you're looking to compile clippy with the current nightly you can do that from the main rust repo, src/tools/clippy is the code that's built for public installation, this repo is to aid the development of Clippy

@EFanZh
Copy link
Author

EFanZh commented Sep 13, 2023

I am using the clippy_utils crate for developing dylint programs. I need to add the clippy_utils that matches the toolchain I am using (currently nightly-2023-09-10) to my Cargo.toml as a lib dependency. I can’t add this dependency from the rust repository because the repository is too big, so I have to use a version from the rust-clippy repository.

@smoelius
Copy link
Contributor

Hey, @EFanZh. Sorry to hijack your issue, but this sounds like more of a Dylint problem. Perhaps we could discuss there?

@flip1995
Copy link
Member

flip1995 commented Sep 13, 2023

Clippy is synced every other week. Next sync is on 2023-09-21. Since this is the first issue ever opened for dylint conflicts with the rust toolchain used to compile Clippy, I'd rather not do a out-of-cycle sync for this.

Why can't you use an older nightly toolchain for you dylint?

@EFanZh
Copy link
Author

EFanZh commented Sep 13, 2023

@flip1995 There is a certain bugfix of the Rust compiler required by our project, and it is only included in nightly-2023-09-10 or later version.

@flip1995
Copy link
Member

What's the bugfix? Do you have a PR?

@EFanZh
Copy link
Author

EFanZh commented Sep 14, 2023

This one: rust-lang/rust#115638. Since the next sync is only 7 days later, I think I’ll just wait till then. Thank you all for your help!

@EFanZh EFanZh closed this as completed Sep 14, 2023
@flip1995
Copy link
Member

FYI: I finally got to the toolchain update: #11563

Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants