Swapped plain with so help function is visually attached to method

Author: rommeld

clippy_lints/src/methods/chunks_exact_with_const_size.rs

@@ -40,7 +40,7 @@ pub(super) fn check(
         let mut applicability = Applicability::MachineApplicable;
         let arg_str = snippet_with_applicability(cx, arg.span, "_", &mut applicability);
 
-        let as_chunks = format!("{suggestion_method}::<{arg_str}>()");
+        let as_chunks = format_args!("{suggestion_method}::<{arg_str}>()");
 
         span_lint_and_then(
             cx,
@@ -49,7 +49,7 @@ pub(super) fn check(
             format!("using `{method_name}` with a constant chunk size"),
             |diag| {
                 if let Node::LetStmt(let_stmt) = cx.tcx.parent_hir_node(expr.hir_id) {
-                    diag.help(format!("consider using `{as_chunks}` instead"));
+                    diag.span_help(call_span, format!("consider using `{as_chunks}` instead"));
 
                     // Try to extract the variable name to provide a more helpful note
                     if let PatKind::Binding(_, _, ident, _) = let_stmt.pat.kind {

tests/ui/chunks_exact_with_const_size.stderr

@@ -4,7 +4,11 @@ error: using `chunks_exact` with a constant chunk size
 LL |     let result = slice.chunks_exact(4);
    |                        ^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks::<4>()` instead
+help: consider using `as_chunks::<4>()` instead
+  --> tests/ui/chunks_exact_with_const_size.rs:9:24
+   |
+LL |     let result = slice.chunks_exact(4);
+   |                        ^^^^^^^^^^^^^^^
    = note: you can access the chunks using `result.0.iter()`, and the remainder using `result.1`
    = note: `-D clippy::chunks-exact-with-const-size` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_with_const_size)]`
@@ -15,7 +19,11 @@ error: using `chunks_exact` with a constant chunk size
 LL |     let result = slice.chunks_exact(CHUNK_SIZE);
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks::<CHUNK_SIZE>()` instead
+help: consider using `as_chunks::<CHUNK_SIZE>()` instead
+  --> tests/ui/chunks_exact_with_const_size.rs:14:24
+   |
+LL |     let result = slice.chunks_exact(CHUNK_SIZE);
+   |                        ^^^^^^^^^^^^^^^^^^^^^^^^
    = note: you can access the chunks using `result.0.iter()`, and the remainder using `result.1`
 
 error: using `chunks_exact` with a constant chunk size
@@ -24,7 +32,11 @@ error: using `chunks_exact` with a constant chunk size
 LL |     let result = slice.chunks_exact(3);
    |                        ^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks::<3>()` instead
+help: consider using `as_chunks::<3>()` instead
+  --> tests/ui/chunks_exact_with_const_size.rs:23:24
+   |
+LL |     let result = slice.chunks_exact(3);
+   |                        ^^^^^^^^^^^^^^^
    = note: you can access the chunks using `result.0.iter()`, and the remainder using `result.1`
 
 error: using `chunks_exact_mut` with a constant chunk size
@@ -33,7 +45,11 @@ error: using `chunks_exact_mut` with a constant chunk size
 LL |     let result = arr.chunks_exact_mut(4);
    |                      ^^^^^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks_mut::<4>()` instead
+help: consider using `as_chunks_mut::<4>()` instead
+  --> tests/ui/chunks_exact_with_const_size.rs:28:22
+   |
+LL |     let result = arr.chunks_exact_mut(4);
+   |                      ^^^^^^^^^^^^^^^^^^^
    = note: you can access the chunks using `result.0.iter()`, and the remainder using `result.1`
 
 error: using `chunks_exact` with a constant chunk size
@@ -42,7 +58,11 @@ error: using `chunks_exact` with a constant chunk size
 LL |         .chunks_exact(2);
    |          ^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks::<2>()` instead
+help: consider using `as_chunks::<2>()` instead
+  --> tests/ui/chunks_exact_with_const_size.rs:37:10
+   |
+LL |         .chunks_exact(2);
+   |          ^^^^^^^^^^^^^^^
    = note: you can access the chunks using `result.0.iter()`, and the remainder using `result.1`
 
 error: aborting due to 5 previous errors

tests/ui/chunks_exact_with_const_size_unfixable.stderr

@@ -4,7 +4,11 @@ error: using `chunks_exact` with a constant chunk size
 LL |     let mut chunk_iter = slice.chunks_exact(CHUNK_SIZE);
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks::<CHUNK_SIZE>()` instead
+help: consider using `as_chunks::<CHUNK_SIZE>()` instead
+  --> tests/ui/chunks_exact_with_const_size_unfixable.rs:9:32
+   |
+LL |     let mut chunk_iter = slice.chunks_exact(CHUNK_SIZE);
+   |                                ^^^^^^^^^^^^^^^^^^^^^^^^
    = note: you can access the chunks using `chunk_iter.0.iter()`, and the remainder using `chunk_iter.1`
    = note: `-D clippy::chunks-exact-with-const-size` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_with_const_size)]`
@@ -15,7 +19,11 @@ error: using `chunks_exact_mut` with a constant chunk size
 LL |     let mut chunk_iter = arr2.chunks_exact_mut(CHUNK_SIZE);
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks_mut::<CHUNK_SIZE>()` instead
+help: consider using `as_chunks_mut::<CHUNK_SIZE>()` instead
+  --> tests/ui/chunks_exact_with_const_size_unfixable.rs:16:31
+   |
+LL |     let mut chunk_iter = arr2.chunks_exact_mut(CHUNK_SIZE);
+   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: you can access the chunks using `chunk_iter.0.iter()`, and the remainder using `chunk_iter.1`
 
 error: aborting due to 2 previous errors