CI will fail

Author: Centri3

clippy_lints/src/loops/utils.rs

@@ -76,7 +76,7 @@ impl<'a, 'tcx> Visitor<'tcx> for IncrementVisitor<'a, 'tcx> {
                     ExprKind::Assign(lhs, _, _) if lhs.hir_id == expr.hir_id => {
                         *state = IncrementVisitorVarState::DontWarn;
                     },
-                    ExprKind::AddrOf(BorrowKind::Ref, mutability, _) if mutability == Mutability::Mut => {
+                    ExprKind::AddrOf(BorrowKind::Ref, Mutability::Mut, _) => {
                         *state = IncrementVisitorVarState::DontWarn;
                     },
                     _ => (),
@@ -226,7 +226,7 @@ impl<'a, 'tcx> Visitor<'tcx> for InitializeVisitor<'a, 'tcx> {
                             InitializeVisitorState::DontWarn
                         }
                     },
-                    ExprKind::AddrOf(BorrowKind::Ref, mutability, _) if mutability == Mutability::Mut => {
+                    ExprKind::AddrOf(BorrowKind::Ref, Mutability::Mut, _) => {
                         self.state = InitializeVisitorState::DontWarn;
                     },
                     _ => (),

clippy_lints/src/redundant_guard.rs

@@ -50,6 +50,9 @@ impl<'tcx> LateLintPass<'tcx> for RedundantGuard {
             return;
         };
 
+        // TODO: This should not lint on locals that are used in the body, but that should be simple enough
+        // to fix
+
         for outer_arm in arms {
             let mut app = Applicability::MaybeIncorrect;
             let Some(guard) = outer_arm.guard else {
@@ -116,6 +119,9 @@ impl<'tcx> LateLintPass<'tcx> for RedundantGuard {
             // TODO: I'm not sure if this is always right. Can we always inline rhs? My intuition
             // says no, but I can't find a case where it can't be...
 
+            // ^ My intuition was correct, This will trigger on `input.span` and any function calls. It should
+            // not do that
+
             // `Some(x) if x == Some(2)`
             if let Guard::If(if_expr) = guard
                 && let ExprKind::Binary(bin_op, local, pat) = if_expr.kind