rename to manual_partial_ord_and_ord_impl

Author: Centri3

CHANGELOG.md

@@ -4917,7 +4917,7 @@ Released 2018-09-13
 [`manual_next_back`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_next_back
 [`manual_non_exhaustive`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
 [`manual_ok_or`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_or
-[`manual_partial_ord_impl`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_partial_ord_impl
+[`manual_partial_ord_and_ord_impl`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_partial_ord_and_ord_impl
 [`manual_range_contains`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
 [`manual_rem_euclid`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_rem_euclid
 [`manual_retain`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain

clippy_lints/src/declared_lints.rs

@@ -273,7 +273,7 @@ pub(crate) static LINTS: &[&crate::LintInfo] = &[
     crate::manual_let_else::MANUAL_LET_ELSE_INFO,
     crate::manual_main_separator_str::MANUAL_MAIN_SEPARATOR_STR_INFO,
     crate::manual_non_exhaustive::MANUAL_NON_EXHAUSTIVE_INFO,
-    crate::manual_partial_ord_impl::MANUAL_PARTIAL_ORD_IMPL_INFO,
+    crate::manual_partial_ord_and_ord_impl::MANUAL_PARTIAL_ORD_AND_ORD_IMPL_INFO,
     crate::manual_rem_euclid::MANUAL_REM_EUCLID_INFO,
     crate::manual_retain::MANUAL_RETAIN_INFO,
     crate::manual_slice_size_calculation::MANUAL_SLICE_SIZE_CALCULATION_INFO,

clippy_lints/src/lib.rs

@@ -184,7 +184,7 @@ mod manual_is_ascii_check;
 mod manual_let_else;
 mod manual_main_separator_str;
 mod manual_non_exhaustive;
-mod manual_partial_ord_impl;
+mod manual_partial_ord_and_ord_impl;
 mod manual_rem_euclid;
 mod manual_retain;
 mod manual_slice_size_calculation;
@@ -1014,7 +1014,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
     store.register_late_pass(|_| Box::new(missing_fields_in_debug::MissingFieldsInDebug));
     store.register_late_pass(|_| Box::new(endian_bytes::EndianBytes));
     store.register_late_pass(|_| {
-        Box::new(manual_partial_ord_impl::ManualPartialOrdImpl {
+        Box::new(manual_partial_ord_and_ord_impl::ManualPartialOrdAndOrdImpl {
             ord_def_id: std::cell::OnceCell::new(),
         })
     });

clippy_lints/src/manual_partial_ord_impl.rs renamed to clippy_lints/src/manual_partial_ord_and_ord_impl.rs

@@ -16,7 +16,7 @@ declare_clippy_lint! {
     ///
     /// ### Why is this bad?
     /// If both `PartialOrd` and `Ord` are implemented, `PartialOrd` will wrap the returned value of
-    /// `Ord::cmp` in `Some`. Not doing this may silently introduce an error.
+    /// `Ord::cmp` in `Some`. Not doing this may silently introduce an error upon refactoring.
     ///
     /// ### Example
     /// ```rust
@@ -53,18 +53,18 @@ declare_clippy_lint! {
     /// }
     /// ```
     #[clippy::version = "1.71.0"]
-    pub MANUAL_PARTIAL_ORD_IMPL,
-    nursery,
+    pub MANUAL_PARTIAL_ORD_AND_ORD_IMPL,
+    correctness,
     "default lint description"
 }
-impl_lint_pass!(ManualPartialOrdImpl => [MANUAL_PARTIAL_ORD_IMPL]);
+impl_lint_pass!(ManualPartialOrdAndOrdImpl => [MANUAL_PARTIAL_ORD_AND_ORD_IMPL]);
 
 #[derive(Clone)]
-pub struct ManualPartialOrdImpl {
+pub struct ManualPartialOrdAndOrdImpl {
     pub ord_def_id: OnceCell<DefId>,
 }
 
-impl LateLintPass<'_> for ManualPartialOrdImpl {
+impl LateLintPass<'_> for ManualPartialOrdAndOrdImpl {
     fn check_item(&mut self, cx: &LateContext<'_>, item: &Item<'_>) {
         if_chain! {
             if let ItemKind::Impl(imp) = &item.kind;
@@ -77,7 +77,7 @@ impl LateLintPass<'_> for ManualPartialOrdImpl {
     }
 }
 
-fn lint_impl_body(conf: &mut ManualPartialOrdImpl, cx: &LateContext<'_>, imp: &Impl<'_>, item: &Item<'_>) {
+fn lint_impl_body(conf: &mut ManualPartialOrdAndOrdImpl, cx: &LateContext<'_>, imp: &Impl<'_>, item: &Item<'_>) {
     for imp_item in imp.items {
         if_chain! {
             if imp_item.ident.name == sym!(partial_cmp);
@@ -102,7 +102,7 @@ fn lint_impl_body(conf: &mut ManualPartialOrdImpl, cx: &LateContext<'_>, imp: &I
                         else {
                             span_lint_and_then(
                                 cx,
-                                MANUAL_PARTIAL_ORD_IMPL,
+                                MANUAL_PARTIAL_ORD_AND_ORD_IMPL,
                                 item.span,
                                 "manual implementation of `PartialOrd` when `Ord` is already implemented",
                                 |diag| {

tests/ui/manual_partial_ord_impl.rs renamed to tests/ui/manual_partial_ord_and_ord_impl.rs

@@ -1,5 +1,13 @@
+error: unknown lint: `clippy::manual_partial_ord_impl`
+  --> $DIR/manual_partial_ord_and_ord_impl.rs:2:9
+   |
+LL | #![warn(clippy::manual_partial_ord_impl)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::manual_partial_ord_and_ord_impl`
+   |
+   = note: `-D unknown-lints` implied by `-D warnings`
+
 error: manual implementation of `PartialOrd` when `Ord` is already implemented
-  --> $DIR/manual_partial_ord_impl.rs:18:1
+  --> $DIR/manual_partial_ord_and_ord_impl.rs:18:1
    |
 LL | /  impl PartialOrd for A {
 LL | |      fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
@@ -10,10 +18,10 @@ LL | ||     }
 LL | |  }
    | |__^
    |
-   = note: `-D clippy::manual-partial-ord-impl` implied by `-D warnings`
+   = note: `#[deny(clippy::manual_partial_ord_and_ord_impl)]` on by default
 
 error: manual implementation of `PartialOrd` when `Ord` is already implemented
-  --> $DIR/manual_partial_ord_impl.rs:52:1
+  --> $DIR/manual_partial_ord_and_ord_impl.rs:52:1
    |
 LL | / impl PartialOrd for C {
 LL | |     fn partial_cmp(&self, _: &Self) -> Option<Ordering> {
@@ -24,5 +32,5 @@ LL | | }
    |
    = help: return the value of `self.cmp` wrapped in `Some` instead
 
-error: aborting due to 2 previous errors
+error: aborting due to 3 previous errors