rustup: rust-lang/rust#71628

Author: csmoe

clippy_lints/src/lib.rs

@@ -5,6 +5,7 @@
 #![feature(or_patterns)]
 #![feature(rustc_private)]
 #![feature(stmt_expr_attributes)]
+#![feature(impl_trait_in_bindings)]
 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
 #![recursion_limit = "512"]
 #![warn(rust_2018_idioms, trivial_casts, trivial_numeric_casts)]

clippy_lints/src/needless_pass_by_value.rs

@@ -111,7 +111,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
 
         let fn_def_id = cx.tcx.hir().local_def_id(hir_id);
 
-        let preds = traits::elaborate_predicates(cx.tcx, cx.param_env.caller_bounds.to_vec())
+        let preds = traits::elaborate_predicates(cx.tcx, cx.param_env.caller_bounds.iter().copied())
             .filter(|p| !p.is_global())
             .filter_map(|obligation| {
                 if let ty::Predicate::Trait(poly_trait_ref, _) = obligation.predicate {

clippy_lints/src/utils/mod.rs

@@ -1384,13 +1384,12 @@ pub fn is_trait_impl_item(cx: &LateContext<'_, '_>, hir_id: HirId) -> bool {
 /// ```
 pub fn fn_has_unsatisfiable_preds(cx: &LateContext<'_, '_>, did: DefId) -> bool {
     use rustc_trait_selection::traits;
-    let predicates = cx
+    let predicates: impl Iterator<Item = ty::Predicate<'_>> = cx
         .tcx
         .predicates_of(did)
         .predicates
         .iter()
-        .filter_map(|(p, _)| if p.is_global() { Some(*p) } else { None })
-        .collect();
+        .filter_map(|(p, _)| if p.is_global() { Some(*p) } else { None });
     !traits::normalize_and_test_predicates(
         cx.tcx,
         traits::elaborate_predicates(cx.tcx, predicates)