Preserve comments when dumping preprocessed input headers #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -C flag tells Clang's preprocessor not to strip comments, but unfortunately Clang will only accept it when dumping the preprocessed file to stdout, which is the -E flag. This means that we need to capture the child process's stdout and then copy it to a file ourselves now.
emilio
approved these changes
Jul 17, 2017
src/lib.rs
Outdated
| Ok(()) | ||
| } else { | ||
| Err(io::Error::new(io::ErrorKind::Other, | ||
| "clang exited with non-zero status")) |
For very large logs to stdout, this prevents deadlocks.
fitzgen
force-pushed
the
include-comments-in-preprocessed-file
branch
from
5c7e3b6 to
02da653
Compare
|
Thanks for the review :) Force pushed an indentation fix. @bors-servo r=emilio |
|
📌 Commit 02da653 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 18, 2017
…=emilio Preserve comments when dumping preprocessed input headers It should be really easy to generate standalone, isolated test cases for bindgen bugs now \o/ See each commit for further details. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be really easy to generate standalone, isolated test cases for bindgen bugs now \o/
See each commit for further details.
r? @emilio