Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple refactoring of derive_partialeq_or_partialord #1119

Merged

Conversation

pepyakin
Copy link
Contributor

Just simple refactoring with some tricks from #1102

r? @fitzgen

@pepyakin pepyakin force-pushed the derive-partialeq-partialord-refactoring branch from 25c7f97 to 916a70f Compare October 30, 2017 05:52
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but there is trailing whitespace in the doc comment of CanDerive.

With that fixed, r=me

@pepyakin pepyakin force-pushed the derive-partialeq-partialord-refactoring branch from 916a70f to 230545e Compare October 30, 2017 14:51
@pepyakin
Copy link
Contributor Author

Eagle eye!

@bors-servo r=emilio

@bors-servo
Copy link

📌 Commit 230545e has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 230545e with merge 3d623d3...

bors-servo pushed a commit that referenced this pull request Oct 30, 2017
…g, r=emilio

Simple refactoring of derive_partialeq_or_partialord

Just simple refactoring with some tricks from #1102

r? @fitzgen
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing 3d623d3 to master...

@bors-servo bors-servo merged commit 230545e into rust-lang:master Oct 30, 2017
@pepyakin pepyakin deleted the derive-partialeq-partialord-refactoring branch October 30, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants