Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt the codebase #1618

Closed
lopopolo opened this issue Sep 15, 2019 · 2 comments · Fixed by #1621
Closed

rustfmt the codebase #1618

lopopolo opened this issue Sep 15, 2019 · 2 comments · Fixed by #1621

Comments

@lopopolo
Copy link
Contributor

From GH-1615:

@emilio I have rustfmt enabled by default on save in my editor and there was quite a lot of diff to ignore to make this PR minimal. Can we either rustfmt bindgen and add a step to CI to enforce code is formatted or add a rustfmt.toml so the formatting is preserved?
@lopopolo lopopolo mentioned this issue Sep 15, 2019
Merged
@emilio
Copy link
Contributor

emilio commented Sep 17, 2019

Yeah, we used to do it, but had to disable because rust-lang/rustfmt#1376. We can re-enable it now, I'll put up a patch.

@emilio emilio mentioned this issue Sep 17, 2019
Merged
@emilio
Copy link
Contributor

emilio commented Sep 17, 2019

Opened #1621 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure formatted code on automation. emilio/rust-bindgen
2 participants
@lopopolo @emilio