Add support for non_exhaustive rustified enums. #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the feature discussed in #1554.
emilio
requested changes
Jun 10, 2019
There was a problem hiding this comment.
Implementation-wise looks good! Mostly some requests about naming / API shape and the test needs to be fixed. But we can totally land features that work only on nightly, as long as it's reflected properly on the rust_target, so no need to wait for stabilization.
Will panic if the feature is being used outside nightly. See #1575 (comment)
emilio
approved these changes
Jun 12, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the feature discussed in #1554.