Produce a more useful error message when rustfmt can't be found. Fixes #1205 #1501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change bindgen would simply print any error that occurred
while attempting to run rustfmt straight to stderr using
fmt::Debug
.Combined with the fact that rustfmt is enabled by default now this meant
that if rustfmt was missing or not working a cryptic error would be
printed.
Without this patch:
With this patch:
I changed the error handling to use
fmt::Display
instead, since thisis user-visible output, and also added "Failed to run rustfmt:" to make the
source of the error clearer. Additionally since bindgen does not treat this
as fatal I noted that in the output as well.