Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unwrap header metadata #1146

Merged
merged 1 commit into from Nov 10, 2017
Merged

Don't unwrap header metadata #1146

merged 1 commit into from Nov 10, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2017

Fix for a comment in #1092.
r? @fitzgen

@emilio
Copy link
Contributor

emilio commented Nov 10, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit 7f0aa6c has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 7f0aa6c with merge c54e64c...

bors-servo pushed a commit that referenced this pull request Nov 10, 2017
Don't unwrap header metadata

Fix for a comment in #1092.
r? @fitzgen
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing c54e64c to master...

@bors-servo bors-servo merged commit 7f0aa6c into rust-lang:master Nov 10, 2017
@fitzgen
Copy link
Member

fitzgen commented Nov 10, 2017

Thanks @seemyvest !

Copy link

@chaosprint chaosprint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"error: header '{}' does not exist." may not always be the case in else branch. There might be other possibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants