Detect #pragma pack(...) and make pack(n) where n > 1 opaque
#1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
☔ The latest upstream changes (presumably #1137) made this pull request unmergeable. Please resolve the merge conflicts. |
This is a bandaid for rust-lang#537. It does *not* fix the underlying issue, which requires `#[repr(packed = "N")]` support in Rust. However, it does make sure that we don't generate type definitions with the wrong layout, or fail our generated layout tests.
fitzgen
force-pushed
the
pragma-pack-bandaid
branch
from
11b3429 to
79dbe8b
Compare
|
@bors-servo r=emilio Thanks @emilio :) |
|
📌 Commit 79dbe8b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 2, 2017
Detect `#pragma pack(...)` and make `pack(n)` where `n > 1` opaque This is a bandaid for #537. It does *not* fix the underlying issue, which requires `#[repr(packed = "N")]` support in Rust. However, it does make sure that we don't generate type definitions with the wrong layout, or fail our generated layout tests. r? @emilio or @pepyakin
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bandaid for #537. It does not fix the underlying issue, which requires
#[repr(packed = "N")]support in Rust. However, it does make sure that we don't generate type definitions with the wrong layout, or fail our generated layout tests.r? @emilio or @pepyakin