Add --no-hash <regex> flag #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
☔ The latest upstream changes (presumably #1099) made this pull request unmergeable. Please resolve the merge conflicts. |
fitzgen
approved these changes
Oct 26, 2017
|
@bors-servo delegate+ Ah, looks like some merge conflicts snuck in. Once you've rebased and resolved them you can tell Thanks again! |
|
✌️ @seemyvest can now approve this pull request |
|
No problem :) @bors-servo r+ I'll have a look and see what others I can do, feel free to point some out to me :) |
|
📌 Commit 5d27156 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 27, 2017
Add --no-hash <regex> flag Issue #964 - [x] Adding a new RegexSet member to bindgen::Builder (similar to the whitelisted_types set). - [x] A Builder method to add strings to that RegexSet. - [x] Plumbing in src/options.rs to convert --no-hash <regex> CLI flags into invocations of the builder method. - [x] Making the MonotoneFramework::constrain function in src/ir/analysis/derive_hash.rs check if the given item is explicitly marked not to be Hash, and if so, inserting it into the self.cannot_derive_hash set via return self.insert(id). - [x] Tests! - [x] When the no-hash type is transitively referenced by a whitelisted item - [x] When the no-hash type is explicitly whitelisted - [x] When the no-hash type is marked opaque r? @fitzgen
|
☀️ Test successful - status-travis |
bors-servo
pushed a commit
that referenced
this pull request
Oct 27, 2017
give better variable name Fixing up a comment from #1105
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #964
Adding a new RegexSet member to bindgen::Builder (similar to the whitelisted_types set).
A Builder method to add strings to that RegexSet.
Plumbing in src/options.rs to convert --no-hash CLI flags into invocations of the builder method.
Making the MonotoneFramework::constrain function in src/ir/analysis/derive_hash.rs check if the given item is explicitly marked not to be Hash, and if so, inserting it into the self.cannot_derive_hash set via return self.insert(id).
Tests!
When the no-hash type is transitively referenced by a whitelisted item
When the no-hash type is explicitly whitelisted
When the no-hash type is marked opaque
r? @fitzgen