Resolve #962 - implement --no-copy with tests #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generated bindings from test headers
|
|
|
r?@fitzgen |
fitzgen
approved these changes
Oct 25, 2017
There was a problem hiding this comment.
Looks great! 👍
Could you also extend the documentation at https://rust-lang-nursery.github.io/rust-bindgen/nocopy.html to account for this change? (book/src/nocopy.md)
Thanks @hallfox !
src/ir/context.rs
Outdated
| @@ -2455,8 +2455,16 @@ impl BindgenContext { | |||
| /// Check if `--no-partialeq` flag is enabled for this item. | |||
| pub fn no_partialeq_by_name(&self, item: &Item) -> bool { | |||
| let name = item.canonical_path(self)[1..].join("::"); | |||
|
|
|||
There was a problem hiding this comment.
Nitpick: no need for this new line.
|
@bors-servo delegate+ |
|
✌️ @hallfox can now approve this pull request |
|
@bors-servo r+ |
|
📌 Commit f7e370a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 26, 2017
Resolve #962 - implement --no-copy with tests Allows types to not have the copy trait automatically derived.
|
☀️ Test successful - status-travis |
This was referenced Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows types to not have the copy trait automatically derived.