Translate _ as __ #1008
Merged
Translate _ as __ #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
We attempt to handle this sort of thing during the codegen phase, and have a map of method names and field names where we count how many times a name has been seen, and append that number to the name for disambiguation. So you get It isn't perfect, but... shrug |
|
@bors-servo r+ |
|
📌 Commit aa11524 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 21, 2017
Translate _ as __ This change treats _ as a reserved identifier to resolve the bug reported in #631. I have one concern - if the header has both an `_` and `__` identifier in the global namespace, this will cause a conflict. However, it seems like we already don't handle that case for `keyword_` (e.g. `abstract_`, `alignof_`, etc.) so it doesn't seem like we need a solution specifically for `__` in this change. Fixes #631.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change treats _ as a reserved identifier to resolve the bug reported in #631.
I have one concern - if the header has both an
_and__identifier in the global namespace, this will cause a conflict. However, it seems like we already don't handle that case forkeyword_(e.g.abstract_,alignof_, etc.) so it doesn't seem like we need a solution specifically for__in this change.Fixes #631.