Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to enabling build script and proc macro support by default #6279

Closed
lnicola opened this issue Oct 19, 2020 · 2 comments
Closed

Path to enabling build script and proc macro support by default #6279

lnicola opened this issue Oct 19, 2020 · 2 comments
Labels
S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@lnicola
Copy link
Member

lnicola commented Oct 19, 2020

We've had a couple issue reports that turned out to be fixed by enabling build script and/or proc macro support. I think the reason these are off by default is that they can slow down the first load of a project by a lot. On the other hand, it's clear that they are needed to provide a good IDE experience.

So I think we'll want to turn them on in the future. The question, then, is when we should do that. We could:

  • enable them right now
  • wait for better proc macro support (to offset the loading cost with even better IDE support)
  • wait for a sandboxing story (which won't happen on a reasonable timeline)
  • anything else?
@lnicola lnicola added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Oct 19, 2020
@bjorn3
Copy link
Member

bjorn3 commented Oct 19, 2020

Another option would be to add a diagnostic for env!("OUT_DIR") and #[derive(SomeProcMacroDerive)] when the respective features are disabled to enable them. This won't help for dependencies, but it could for the current crate without the drawbacks associated with always enabling them.

@lnicola
Copy link
Member Author

lnicola commented Nov 3, 2020

Closing in favor of #6448.

@lnicola lnicola closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Development

No branches or pull requests

2 participants