Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper serversided config interpolation #13297

Closed
Veykril opened this issue Sep 26, 2022 · 1 comment
Closed

Proper serversided config interpolation #13297

Veykril opened this issue Sep 26, 2022 · 1 comment
Assignees
Labels
A-config configuration C-feature Category: feature request E-unknown It's unclear if the issue is E-hard or E-easy without digging in

Comments

@Veykril
Copy link
Member

Veykril commented Sep 26, 2022

#13128 implements a very basic interpolation option for querying the manifest path of the workspace a command is being run for.

This gave me the idea that we could rename the overrideCommand configs to just command, remove the null default for them and redefine the current default command in terms of interpolations.
For that we need a proper interpolation system that allows us to do a variety of things, the aforementioned PR currently just allows $manifest_path to be substituted, but we want to be able to do more than simple substitution here (like simplistic conditional inclusion e.g ${var:value}, if var then value) ...

@Veykril
Copy link
Member Author

Veykril commented Oct 21, 2022

After some thinking, this seems like a bad choice to do in a general thing as this is a huuuuge task. We are probably better off with just using a bit of simple interpolation bits for the overrideCommands that make integration with non cargo based build systems better

@Veykril Veykril closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config configuration C-feature Category: feature request E-unknown It's unclear if the issue is E-hard or E-easy without digging in
Projects
None yet
Development

No branches or pull requests

1 participant