This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Don't forcibly set CARGO_MANIFEST_DIR as a workaround for Clippy #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't regress our scenario since in Clippy it falls back to current directory (which we set appropriately in the cached build plan case) and gets rid of a now unnecessary workaround, so merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled by rust-lang/rust-clippy#3665.
When using Cargo build plan we always have
CARGO_MANIFEST_DIRset so I believe this was done to support external build plan work.r? @jsgf