Add a count parameter to the expect attribute #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey and thank you for the RFC! Currently, there is a discussion in the tracking issue rust-lang/rust#54503 and on Zulip what lint emission should actually be suppressed and fulfill the lint expectation. I would recommend putting this RFC on hold, until a decision was made in that regard. |
xFrednet
added
the
T-lang
teor2345
reviewed
Mar 17, 2023
| # Unresolved questions | ||
| [unresolved-questions]: #unresolved-questions | ||
|
|
||
| - Can we allow `#[expect(..., count = 0)]` with some useful behavior? What about |
There was a problem hiding this comment.
expect(lint, count = 0) seems like it should be the same as deny(lint).
There was a problem hiding this comment.
Agreed. I could see count = 0 being convenient for a tool that decreases the expected count when it is too high. Such a tool would then not have to deal with this edge case.
In my mind expect(lint, count = 0) should compile with a warning (or clippy lint) suggesting using deny instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC proposes extending the
expectattribute` from #2383Rendered