Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion shouldn't use curl to download manifests #18

Open
aidanhs opened this issue Jun 19, 2018 · 2 comments
Open

Promotion shouldn't use curl to download manifests #18

aidanhs opened this issue Jun 19, 2018 · 2 comments
Labels
A-reliability Issue that affects the reliability and operations of promote-release C-bug Issue that needs to be fixed

Comments

@aidanhs
Copy link
Member

aidanhs commented Jun 19, 2018

This may cause it to download older manifests that we've hacked around with by hand and forgotten to flush the cache of.

Instead it should use aws s3 cp --cache-control none.

cc @Mark-Simulacrum

@aidanhs aidanhs changed the title RCS shouldn't use curl to download manifests Promotion shouldn't use curl to download manifests Jun 19, 2018
@Mark-Simulacrum
Copy link
Member

Note that --cache-control none is entirely arbitrary: I have no idea if none is the right thing to pass there.

@alexcrichton
Copy link
Member

Ah using aws s3 cp should be fine, that goes straight to S3 and avoids all caches

@pietroalbini pietroalbini transferred this issue from rust-lang/rust-central-station Oct 26, 2020
@pietroalbini pietroalbini added A-reliability Issue that affects the reliability and operations of promote-release C-bug Issue that needs to be fixed labels Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reliability Issue that affects the reliability and operations of promote-release C-bug Issue that needs to be fixed
Projects
None yet
Development

No branches or pull requests

4 participants