Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch compile-fail tests to ui tests #2027

Closed
RalfJung opened this issue Mar 16, 2022 · 1 comment · Fixed by #2032
Closed

Switch compile-fail tests to ui tests #2027

RalfJung opened this issue Mar 16, 2022 · 1 comment · Fixed by #2032
Assignees
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@RalfJung
Copy link
Member

RalfJung commented Mar 16, 2022

Currently, we use the compile-fail mode of compiletest for our "expected to fail" tests. rustc has switched to ui a long time ago, and it probably would make sense for Miri to follow suit. That would also unblock #2015.

#1977 finally makes this feasible by hiding libstd internals from the default stacktraces.

However, besides making sure we can actually get compiletest to do this properly (miri's needs are somewhat special), we also need to figure out how to support something like --bless. Clippy might be a good template here.

ui tests would also make it much easier to evaluate PRs like #1971.

@RalfJung RalfJung added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement A-tests Area: affects our test suite or CI labels Mar 16, 2022
@oli-obk oli-obk self-assigned this Mar 17, 2022
@bors bors closed this as completed in 0a4279f May 25, 2022
@RalfJung
Copy link
Member Author

Thanks a lot @oli-obk for doing this. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants