Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More breakage: -- in anchors #428

Closed
steveklabnik opened this issue Sep 8, 2017 · 8 comments
Closed

More breakage: -- in anchors #428

steveklabnik opened this issue Sep 8, 2017 · 8 comments

Comments

@steveklabnik
Copy link
Member

steveklabnik commented Sep 8, 2017

Yet more breakage when trying to use mdbook 0.0.24 on the rust book

A heading like this

## `--passes`

used to give #--passes, but now gives passes

## Method-call expressions

used to give #method-call-expressions but now gives #methodcall-expressions

Were these intentional?

This is semi-important to resolve as Rust's build is now warning due to the errors from back in 0.0.22, so cleaning those up soon would be great!

@azerupi
Copy link
Contributor

azerupi commented Sep 8, 2017

I am a little confused. How could ## --passes become #--passes-add-more-rustdoc-passes where does the rest come from?

used to give #method-call-expressions but now gives #methodcall-expressions

The old way seems more sensible. I'm going to take a look, once it is resolved we should definitely make some tests for this because it seems like a portion that is particularly sensitive to breakage.

@steveklabnik
Copy link
Member Author

How could ##--passes`` become #--passes-add-more-rustdoc-passes where does the rest come from?

Ugh sorry, I mis-copy/pasted; the actual title is

## `--passes`: add more rustdoc passes

but since most of that doesn't matter for the purposes of this bug, I removed it. But apparently missed a spot. I will update the original issue.

@azerupi
Copy link
Contributor

azerupi commented Sep 8, 2017

Commit azerupi@84ef4d2 should solve this. Can you test with master? If there is any other breakage, let me know. Otherwise I will do a 0.0.25 release.

I added your two breakage examples to the tests. It is not much, we should probably add more but at least we have already something.

@steveklabnik
Copy link
Member Author

I will test right now 👍

@steveklabnik
Copy link
Member Author

Build completed successfully in 0:04:50

🎊

@azerupi
Copy link
Contributor

azerupi commented Sep 8, 2017

I will release a new version then! :)

@azerupi
Copy link
Contributor

azerupi commented Sep 8, 2017

Version 0.0.25 released!

@azerupi azerupi closed this as completed Sep 8, 2017
@steveklabnik
Copy link
Member Author

rust-lang/rust#44430 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants