Remove fail-on-request-error in GUI tests as they are not needed anymore

Author: GuillaumeGomez

tests/gui/move-between-pages.goml

@@ -1,9 +1,5 @@
 // This tests pressing the left and right arrows moving to previous and next page.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally (due to CORS), but the searchindex.js will succeed.
-fail-on-request-error: false
-
 go-to: |DOC_PATH| + "index.html"
 
 // default page is the first numbered page

tests/gui/search.goml

@@ -1,8 +1,5 @@
 // This tests basic search behavior.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally (due to CORS), but the searchindex.js will succeed.
-fail-on-request-error: false
 go-to: |DOC_PATH| + "index.html"
 
 define-function: (

tests/gui/sidebar-nojs.goml

@@ -2,9 +2,6 @@
 // an iframe (because of JS disabled).
 // Regression test for <https://github.com/rust-lang/mdBook/issues/2528>.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally.
-fail-on-request-error: false
 // We disable javascript
 javascript: false
 go-to: |DOC_PATH| + "index.html"

tests/gui/sidebar.goml

@@ -1,9 +1,6 @@
 // This GUI test checks sidebar hide/show and also its behaviour on smaller
 // width.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally.
-fail-on-request-error: false
 go-to: |DOC_PATH| + "index.html"
 set-window-size: (1100, 600)
 // Need to reload for the new size to be taken account by the JS.