Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX: dlopen flags for RTLD_MEMBER and RTLD_NOAUTODEFER #4044

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

mustartt
Copy link

On AIX, we can dlopen an ar archive directly with RTLD_MEMBER flag.
https://www.ibm.com/docs/en/aix/7.3?topic=d-dlopen-subroutine

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI doesn't pass with the latest nightly so I'll merge it tomorrow.

@mustartt
Copy link
Author

Thanks for taking a look. Is this a good candidate for libc-0.2? It would be nice to have this in rustc relatively soon

@tgross35
Copy link
Contributor

Indeed, just forgot to label

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 15, 2024
@tgross35 tgross35 added this pull request to the merge queue Nov 16, 2024
Merged via the queue into rust-lang:main with commit eb00e57 Nov 16, 2024
43 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
(backport <rust-lang#4044>)
(cherry picked from commit 17a88cc)
@tgross35 tgross35 mentioned this pull request Nov 16, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
(backport <rust-lang#4044>)
(cherry picked from commit 17a88cc)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
(backport <rust-lang#4044>)
(cherry picked from commit 17a88cc)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
(backport <rust-lang#4044>)
(cherry picked from commit 17a88cc)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants