From 4e82ee6998753f49f4ac6c08459e8cdc0d0c66a6 Mon Sep 17 00:00:00 2001 From: Yuki Okushi Date: Thu, 20 Apr 2023 04:27:39 +0900 Subject: [PATCH] Mention unstable values on PR template Signed-off-by: Yuki Okushi --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a4958ba8c5e64..3e49d7473fdc5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,8 +3,10 @@ Thanks for considering submitting a PR! Here's a checklist for things that will be checked during review or continuous integration. - \[ ] Edit corresponding file(s) under `libc-test/semver` when you add/remove item(s) +- \[ ] Your PR doesn't contain any *unstable* values like `*LAST` or `*MAX` (see [#3131](https://github.com/rust-lang/libc/issues/3131)) +- \[ ] If your PR increments version number, it must not contain any other changes - \[ ] `rustc ci/style.rs && ./style src` -- \[ ] `cd libc-test && cargo test` (This might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure.) -- \[ ] Your PR that bumps up the crate version doesn't contain any other changes +- \[ ] `cd libc-test && cargo test` + - (this might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure) Delete this line and everything above before opening your PR.