Skip to content

Commit 91a3082

Browse files
lvllvllvllvl
committed
chore: add labels to FIXMEs
1 parent 1f68d57 commit 91a3082

File tree

1 file changed

+37
-37
lines changed

1 file changed

+37
-37
lines changed

‎libc-test/build.rs‎

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -4109,29 +4109,29 @@ fn test_linux(target: &str) {
41094109
| "CANXL_XLF"
41104110
=> true,
41114111

4112-
// FIXME: Parts of netfilter/nfnetlink*.h require more recent kernel headers:
4112+
// FIXME(linux): Parts of netfilter/nfnetlink*.h require more recent kernel headers:
41134113
| "RTNLGRP_MCTP_IFADDR" // linux v5.17+
41144114
| "RTNLGRP_TUNNEL" // linux v5.18+
41154115
| "RTNLGRP_STATS" // linux v5.18+
41164116
=> true,
41174117

4118-
// FIXME: The below is no longer const in glibc 2.34:
4118+
// FIXME(linux): The below is no longer const in glibc 2.34:
41194119
// https://github.com/bminor/glibc/commit/5d98a7dae955bafa6740c26eaba9c86060ae0344
41204120
| "PTHREAD_STACK_MIN"
41214121
| "SIGSTKSZ"
41224122
| "MINSIGSTKSZ"
41234123
if gnu => true,
41244124

4125-
// FIXME: Linux >= 5.16:
4125+
// FIXME(linux): Linux >= 5.16:
41264126
// https://github.com/torvalds/linux/commit/42df6e1d221dddc0f2acf2be37e68d553ad65f96
41274127
"NF_NETDEV_EGRESS" if sparc64 => true,
41284128
// value changed
41294129
"NF_NETDEV_NUMHOOKS" if sparc64 => true,
41304130

4131-
// FIXME: requires Linux >= v5.8
4131+
// FIXME(linux): requires Linux >= v5.8
41324132
"IF_LINK_MODE_TESTING" if sparc64 => true,
41334133

4134-
// FIXME: Requires >= 6.3 kernel headers
4134+
// FIXME(linux): Requires >= 6.3 kernel headers
41354135
"MFD_EXEC" | "MFD_NOEXEC_SEAL" if sparc64 => true,
41364136

41374137
// kernel 6.1 minimum
@@ -4140,7 +4140,7 @@ fn test_linux(target: &str) {
41404140
// kernel 6.2 minimum
41414141
"TUN_F_USO4" | "TUN_F_USO6" | "IFF_NO_CARRIER" => true,
41424142

4143-
// FIXME: Requires more recent kernel headers
4143+
// FIXME(linux): Requires more recent kernel headers
41444144
| "IFLA_PARENT_DEV_NAME" // linux v5.13+
41454145
| "IFLA_PARENT_DEV_BUS_NAME" // linux v5.13+
41464146
| "IFLA_GRO_MAX_SIZE" // linux v5.16+
@@ -4153,10 +4153,10 @@ fn test_linux(target: &str) {
41534153

41544154
// kernel 6.5 minimum
41554155
"MOVE_MOUNT_BENEATH" => true,
4156-
// FIXME: Requires linux 6.1
4156+
// FIXME(linux): Requires linux 6.1
41574157
"ALG_SET_KEY_BY_KEY_SERIAL" | "ALG_SET_DRBG_ENTROPY" => true,
41584158

4159-
// FIXME: Requires more recent kernel headers
4159+
// FIXME(linux): Requires more recent kernel headers
41604160
| "FAN_FS_ERROR" // linux v5.16+
41614161
| "FAN_RENAME" // linux v5.17+
41624162
| "FAN_REPORT_TARGET_FID" // linux v5.17+
@@ -4184,18 +4184,18 @@ fn test_linux(target: &str) {
41844184
| "FAN_EPIDFD"
41854185
if musl => true,
41864186

4187-
// FIXME: Requires linux 6.5
4187+
// FIXME(linux): Requires linux 6.5
41884188
"NFT_MSG_MAX" => true,
41894189

4190-
// FIXME: Requires >= 6.6 kernel headers.
4190+
// FIXME(linux): Requires >= 6.6 kernel headers.
41914191
"XDP_USE_SG"
41924192
| "XDP_PKT_CONTD"
41934193
=>
41944194
{
41954195
true
41964196
}
41974197

4198-
// FIXME: Requires >= 6.8 kernel headers.
4198+
// FIXME(linux): Requires >= 6.8 kernel headers.
41994199
"XDP_UMEM_TX_SW_CSUM"
42004200
| "XDP_TXMD_FLAGS_TIMESTAMP"
42014201
| "XDP_TXMD_FLAGS_CHECKSUM"
@@ -4205,20 +4205,20 @@ fn test_linux(target: &str) {
42054205
true
42064206
}
42074207

4208-
// FIXME: Requires >= 6.11 kernel headers.
4208+
// FIXME(linux): Requires >= 6.11 kernel headers.
42094209
"XDP_UMEM_TX_METADATA_LEN"
42104210
=>
42114211
{
42124212
true
42134213
}
42144214

4215-
// FIXME: Requires >= 6.6 kernel headers.
4215+
// FIXME(linux): Requires >= 6.6 kernel headers.
42164216
"SYS_fchmodat2" => true,
42174217

4218-
// FIXME: Requires >= 6.10 kernel headers.
4218+
// FIXME(linux): Requires >= 6.10 kernel headers.
42194219
"SYS_mseal" => true,
42204220

4221-
// FIXME: seems to not be available all the time (from <include/linux/sched.h>:
4221+
// FIXME(linux): seems to not be available all the time (from <include/linux/sched.h>:
42224222
"PF_VCPU"
42234223
| "PF_IDLE"
42244224
| "PF_EXITING"
@@ -4247,11 +4247,11 @@ fn test_linux(target: &str) {
42474247
| "PF_BLOCK_TS"
42484248
| "PF_SUSPEND_TASK" => true,
42494249

4250-
// FIXME: Requires >= 6.9 kernel headers.
4250+
// FIXME(linux): Requires >= 6.9 kernel headers.
42514251
"EPIOCSPARAMS"
42524252
| "EPIOCGPARAMS" => true,
42534253

4254-
// FIXME: Requires >= 6.11 kernel headers.
4254+
// FIXME(linux): Requires >= 6.11 kernel headers.
42554255
"MAP_DROPPABLE" => true,
42564256

42574257
_ => false,
@@ -4279,7 +4279,7 @@ fn test_linux(target: &str) {
42794279
// test the XSI version below.
42804280
"strerror_r" => true,
42814281

4282-
// FIXME: Our API is unsound. The Rust API allows aliasing
4282+
// FIXME(linux): Our API is unsound. The Rust API allows aliasing
42834283
// pointers, but the C API requires pointers not to alias.
42844284
// We should probably be at least using `&`/`&mut` here, see:
42854285
// https://github.com/gnzlbg/ctest/issues/68
@@ -4290,10 +4290,10 @@ fn test_linux(target: &str) {
42904290
// Needs glibc 2.35 or later.
42914291
"posix_spawn_file_actions_addtcsetpgrp_np" if gnu && sparc64 => true,
42924292

4293-
// FIXME: Deprecated since glibc 2.30. Remove fn once upstream does.
4293+
// FIXME(linux): Deprecated since glibc 2.30. Remove fn once upstream does.
42944294
"sysctl" if gnu => true,
42954295

4296-
// FIXME: It now takes c_void instead of timezone since glibc 2.31.
4296+
// FIXME(linux): It now takes c_void instead of timezone since glibc 2.31.
42974297
"gettimeofday" if gnu => true,
42984298

42994299
// These are all implemented as static inline functions in uclibc, so
@@ -4321,7 +4321,7 @@ fn test_linux(target: &str) {
43214321
// assume it's a int instead.
43224322
"getnameinfo" if uclibc => true,
43234323

4324-
// FIXME: This needs musl 1.2.2 or later.
4324+
// FIXME(musl): This needs musl 1.2.2 or later.
43254325
"gettid" if musl => true,
43264326

43274327
// Needs glibc 2.33 or later.
@@ -4357,7 +4357,7 @@ fn test_linux(target: &str) {
43574357
"posix_basename" if gnu => true,
43584358
"gnu_basename" if gnu => true,
43594359

4360-
// FIXME: function pointers changed since Ubuntu 23.10
4360+
// FIXME(linux): function pointers changed since Ubuntu 23.10
43614361
"strtol" | "strtoll" | "strtoul" | "strtoull" | "fscanf" | "scanf" | "sscanf" => true,
43624362

43634363
// Added in musl 1.2.5
@@ -4419,19 +4419,19 @@ fn test_linux(target: &str) {
44194419
field == "ssi_syscall" ||
44204420
field == "ssi_call_addr" ||
44214421
field == "ssi_arch")) ||
4422-
// FIXME: After musl 1.1.24, it have only one field `sched_priority`,
4422+
// FIXME(musl): After musl 1.1.24, it have only one field `sched_priority`,
44234423
// while other fields become reserved.
44244424
(struct_ == "sched_param" && [
44254425
"sched_ss_low_priority",
44264426
"sched_ss_repl_period",
44274427
"sched_ss_init_budget",
44284428
"sched_ss_max_repl",
44294429
].contains(&field) && musl) ||
4430-
// FIXME: After musl 1.1.24, the type becomes `int` instead of `unsigned short`.
4430+
// FIXME(musl): After musl 1.1.24, the type becomes `int` instead of `unsigned short`.
44314431
(struct_ == "ipc_perm" && field == "__seq" && aarch64_musl) ||
44324432
// glibc uses unnamed fields here and Rust doesn't support that yet
44334433
(struct_ == "timex" && field.starts_with("__unused")) ||
4434-
// FIXME: It now takes mode_t since glibc 2.31 on some targets.
4434+
// FIXME(linux): It now takes mode_t since glibc 2.31 on some targets.
44354435
(struct_ == "ipc_perm" && field == "mode"
44364436
&& ((x86_64 || i686 || arm || riscv64) && gnu || x86_64_gnux32)
44374437
) ||
@@ -4480,9 +4480,9 @@ fn test_linux(target: &str) {
44804480
});
44814481

44824482
cfg.skip_roundtrip(move |s| match s {
4483-
// FIXME:
4483+
// FIXME(ctest):
44844484
"mcontext_t" if s390x => true,
4485-
// FIXME: This is actually a union.
4485+
// FIXME(union): This is actually a union.
44864486
"fpreg_t" if s390x => true,
44874487

44884488
// The test doesn't work on some env:
@@ -4516,7 +4516,7 @@ fn test_linux(target: &str) {
45164516
"fanotify_event_info_fid" => true,
45174517
"cmsghdr" => true,
45184518

4519-
// FIXME: the call ABI of max_align_t is incorrect on these platforms:
4519+
// FIXME(linux): the call ABI of max_align_t is incorrect on these platforms:
45204520
"max_align_t" if i686 || ppc64 => true,
45214521

45224522
_ => false,
@@ -4847,13 +4847,13 @@ fn test_haiku(target: &str) {
48474847
return true;
48484848
}
48494849
match ty {
4850-
// FIXME: actually a union
4850+
// FIXME(union): actually a union
48514851
"sigval" => true,
4852-
// FIXME: locale_t does not exist on Haiku
4852+
// FIXME(haiku): locale_t does not exist on Haiku
48534853
"locale_t" => true,
4854-
// FIXME: rusage has a different layout on Haiku
4854+
// FIXME(haiku): rusage has a different layout on Haiku
48554855
"rusage" => true,
4856-
// FIXME?: complains that rust aligns on 4 byte boundary, but
4856+
// FIXME(haiku): complains that rust aligns on 4 byte boundary, but
48574857
// Haiku does not align it at all.
48584858
"in6_addr" => true,
48594859
// The d_name attribute is an array of 1 on Haiku, with the
@@ -4878,7 +4878,7 @@ fn test_haiku(target: &str) {
48784878

48794879
cfg.skip_type(move |ty| {
48804880
match ty {
4881-
// FIXME: locale_t does not exist on Haiku
4881+
// FIXME(haiku): locale_t does not exist on Haiku
48824882
"locale_t" => true,
48834883
// These cause errors, to be reviewed in the future
48844884
"sighandler_t" => true,
@@ -4893,7 +4893,7 @@ fn test_haiku(target: &str) {
48934893
cfg.skip_fn(move |name| {
48944894
// skip those that are manually verified
48954895
match name {
4896-
// FIXME: does not exist on haiku
4896+
// FIXME(haiku): does not exist on haiku
48974897
"open_wmemstream" => true,
48984898
"mlockall" | "munlockall" => true,
48994899
"tcgetsid" => true,
@@ -4917,7 +4917,7 @@ fn test_haiku(target: &str) {
49174917

49184918
cfg.skip_const(move |name| {
49194919
match name {
4920-
// FIXME: these constants do not exist on Haiku
4920+
// FIXME(haiku): these constants do not exist on Haiku
49214921
"DT_UNKNOWN" | "DT_FIFO" | "DT_CHR" | "DT_DIR" | "DT_BLK" | "DT_REG" | "DT_LNK"
49224922
| "DT_SOCK" => true,
49234923
"USRQUOTA" | "GRPQUOTA" => true,
@@ -4943,7 +4943,7 @@ fn test_haiku(target: &str) {
49434943

49444944
cfg.skip_field(move |struct_, field| {
49454945
match (struct_, field) {
4946-
// FIXME: the stat struct actually has timespec members, whereas
4946+
// FIXME(time): the stat struct actually has timespec members, whereas
49474947
// the current representation has these unpacked.
49484948
("stat", "st_atime") => true,
49494949
("stat", "st_atime_nsec") => true,
@@ -4973,7 +4973,7 @@ fn test_haiku(target: &str) {
49734973
});
49744974

49754975
cfg.skip_roundtrip(move |s| match s {
4976-
// FIXME: for some reason the roundtrip check fails for cpu_info
4976+
// FIXME(ctest): for some reason the roundtrip check fails for cpu_info
49774977
"cpu_info" => true,
49784978
_ => false,
49794979
});

0 commit comments

Comments
 (0)