This repository has been archived by the owner on May 23, 2024. It is now read-only.
15694 is now fixed #156
Merged
15694 is now fixed #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
approved these changes
Oct 2, 2019
|
But I'm not sure we should remove the ICEs, see the issue: #154 |
|
I can move it to a different dir if you prefer We can also leave the decision until later and bring them all back at that point if it's decided to keep it in tree For this one I went with the current precedent e.g. 7a2f7a1 |
|
Okay, so it's worth to create the dir named |
Merged
|
Changed it to be in a directory |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#15694