-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_path_ignored not working on windows #334
Comments
This is likely either a bug in libgit2 or a facet that we need to work around unfortunately :( |
Thanks for diagnosing this though! |
I refined it as far as I can. I don't have the C knowledge to reported up stream. If you have a suggestion for a workaround, I'm all ears. |
We may need to to_string it and convert |
That seems to work locally. Odd that |
Also should we Implement that work around here or in each user of this crates? |
Yeah something like |
The other workaround, probably not worth considering but maybe worth studying, is https://github.com/BurntSushi/ripgrep/tree/master/ignore. |
steps to repro:
start a new cargo project
C:\> cargo new git2-test
thencheck that
.gitignore
includes/target
add
git2 = "*"
toCargo.toml
and the following tomain.rs
(or unzip the file git2-test.zip) and do
cargo run
.output is:
I expected the last line to be
true == true
tested on windows 10 locally, reduced from appveyor testing rust-lang/cargo#5733
The text was updated successfully, but these errors were encountered: