0.2: Fix compilation when "nightly" feature is enabled #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
reviewed
Jun 30, 2018
| @@ -1,6 +1,7 @@ | |||
| use futures::stable::block_on_stable; | |||
| use futures::executor::{block_on, ThreadPool}; | |||
| use futures::prelude::*; | |||
| use futures::prelude::await; | |||
There was a problem hiding this comment.
@ngg Is await not included automatically by the * import above?
There was a problem hiding this comment.
Without this the compiler gives an error "error[E0659]: await is ambiguous", "note: await could refer to the name imported here" (referring to the prelude), "note: await is also a builtin macro", "note: consider adding an explicit import of await to disambiguate". Explicitly importing it solves this.
There was a problem hiding this comment.
Ah, gotcha. Thanks for explaining!
|
@ngg I've published the updates to these three crates. Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the crates are not compiling with the latest nightly compiler when "nightly" feature is enabled (because of rust-lang/rust#51730).
Please release a new version of the "futures-core-preview", "futures-stable-preview" and "futures-async-runtime-preview" after merging this.